feat: Add the template page #1754
Conversation
| @@ -143,4 +144,12 @@ const useStyles = makeStyles((theme) => ({ | |||
| marginRight: theme.spacing(1.5), | |||
| }, | |||
| }, | |||
|
|
|||
| operatingSystem: { | |||
| fontSize: 14, | |||
There was a problem hiding this comment.
should we try to use a typography property here?
There was a problem hiding this comment.
Probably yes
There was a problem hiding this comment.
Since there are more styles involved I will keep it right now.
site/src/components/TemplateResourcesTable/TemplateResourcesTable.tsx
Outdated
Show resolved
Hide resolved
| const { template } = useParams() | ||
|
|
||
| if (!template) { | ||
| throw new Error("No template found in the URL") |
There was a problem hiding this comment.
This is a "never" state because react-router-dom is handling that for us but I'm doing this here to make TS happy and return the correct type.
There was a problem hiding this comment.
Nit: Comment could help clarify that
site/src/hooks/useOrganizationID.ts
Outdated
|
|
||
| export const useOrganizationID = (): string => { | ||
| const xServices = useContext(XServiceContext) | ||
| const [authState] = useActor(xServices.authXService) |
There was a problem hiding this comment.
I think we should do useInterpret and useSelector here so it doesn't cause rerenders for any data except the org id.
There was a problem hiding this comment.
Since this is getting authentication data which is a global state I would use the XServiceContext. About the selector for organization Id, I think it is a good idea.
There was a problem hiding this comment.
Oh you're right, we don't need useInterpret here. But I think we should not have useActor. In fact I don't know if we need a hook for this, you could do it like this
Closes #1734