chore: organize ws stats, schedule stories #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: #1681 Summary: - Moves WorkspaceSchedule out of WorkspaceStats - Adds WorkspaceScheduleForm directory - Adds meaningful stories for WorkspaceStats Impact: Improves breadth of our chromatic visual regression tests since the examples for WorkspaceStats were non-representative of the component
|
Looks great! Just wondering, do you think we need the separate |
Great question! I think it's ok to have the stories at the granular level and composed level, especially if we say add props to |
|
I'll remove them from now, to clear things up a bit --> just I don't have a satisfying answer on what granules to storybook just yet. Hmm. 🤔 |
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
Resolves: #1681 Summary: - Moves WorkspaceSchedule out of WorkspaceStats - Adds WorkspaceScheduleForm directory Impact: Improves breadth of our chromatic visual regression tests since the examples for WorkspaceStats were non-representative of the component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1681
Summary:
Adds meaningful stories for WorkspaceStats(removed in 4f2ad13)Impact:
Improves breadth of our chromatic visual regression tests since the
examples for WorkspaceStats were non-representative of the component