Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hide New user button if no permission #1794

Merged
merged 1 commit into from
May 26, 2022
Merged

fix: hide New user button if no permission #1794

merged 1 commit into from
May 26, 2022

Conversation

presleyp
Copy link
Contributor

Fixes #1742
Storybook now shows the UserPageView with and without create and update permissions

@presleyp presleyp requested a review from a team as a code owner May 26, 2022 18:13
BrunoQuaresma
BrunoQuaresma approved these changes May 26, 2022
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@presleyp presleyp merged commit d2ff590 into main May 26, 2022
@presleyp presleyp deleted the rbac-new-user/presleyp/1742 branch May 26, 2022 18:25
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@presleyp @kylecarbs
fix: hide New user button if no permission (#1794)
9695877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove "New User" button for non-Admins in the User page
2 participants
@presleyp @BrunoQuaresma