Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove provisionerd from Makefile #184

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

bryphe-coder
Copy link
Contributor

This fixes an error that would occur in running make build - there isn't a cmd/provisionerd/main.go available at the moment.

@bryphe-coder bryphe-coder self-assigned this Feb 7, 2022
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #184 (b3cef0d) into main (d55231c) will increase coverage by 2.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   65.47%   67.93%   +2.46%     
==========================================
  Files         103      108       +5     
  Lines        5294     5632     +338     
  Branches       68       68              
==========================================
+ Hits         3466     3826     +360     
+ Misses       1498     1442      -56     
- Partials      330      364      +34     
Flag Coverage Δ
unittest-go-macos-latest 65.64% <ø> (+0.06%) ⬆️
unittest-go-ubuntu-latest 66.83% <ø> (?)
unittest-go-windows-latest 65.34% <ø> (?)
unittest-js 64.66% <ø> (ø)
Impacted Files Coverage Δ
provisioner/terraform/serve.go 68.75% <0.00%> (ø)
coderd/userpassword/userpassword.go 63.41% <0.00%> (ø)
provisioner/terraform/provision.go 75.69% <0.00%> (ø)
provisioner/terraform/parse.go 78.18% <0.00%> (ø)
database/postgres/postgres.go 70.73% <0.00%> (ø)
provisionerd/provisionerd.go 67.70% <0.00%> (+0.95%) ⬆️
peer/conn.go 79.23% <0.00%> (+1.53%) ⬆️
coderd/coderdtest/coderdtest.go 100.00% <0.00%> (+14.87%) ⬆️
database/migrate.go 52.38% <0.00%> (+52.38%) ⬆️
database/pubsub.go 77.08% <0.00%> (+77.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d55231c...b3cef0d. Read the comment docs.

@bryphe-coder bryphe-coder merged commit bea708d into main Feb 7, 2022
@bryphe-coder bryphe-coder deleted the bryphe/refactor/remove-provisionerd-build branch February 7, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants