Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example: docker warning on Coder host #1842

Merged
merged 1 commit into from
May 27, 2022
Merged

example: docker warning on Coder host #1842

merged 1 commit into from
May 27, 2022

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented May 27, 2022

fixes #1814

@bpmct bpmct requested a review from jsjoeio May 27, 2022 15:13
jsjoeio
jsjoeio approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice fix!

@bpmct bpmct merged commit 5000edb into main May 27, 2022
@bpmct bpmct deleted the bpmct/docker-run-warn branch May 27, 2022 18:03
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@bpmct @kylecarbs
example: docker warning on Coder host (#1842)
36a44aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UX: tell user they need to run Docker if they use Docker template
3 participants
@bpmct @jsjoeio @kylecarbs