Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Suspended users cannot authenticate #1849

Merged
merged 18 commits into from
May 31, 2022
Merged

fix: Suspended users cannot authenticate #1849

merged 18 commits into from
May 31, 2022

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented May 27, 2022 •
edited

What this PR does

  • Blocks non 'active' users from authenticating

Screenshot from 2022-05-27 12-10-10

Screenshot from 2022-05-27 13-26-47

TODO:

  • Activate button was removed, so you can only reset the password of a suspended user. Remaining work is to implement that button.

kylecarbs
kylecarbs reviewed May 27, 2022
View reviewed changes
cli/server.go Outdated Show resolved Hide resolved
@Emyrk Emyrk marked this pull request as ready for review May 27, 2022 20:57
@Emyrk Emyrk requested a review from a team as a code owner May 27, 2022 20:57
@Emyrk
Copy link
Member Author

Emyrk commented May 27, 2022

@vapurrmaid @presleyp Currently clicking "activate" does nothing. No indicator or anything. I am guessing I should get that to work in this PR... ? Would be nice to kick the can on that, as this is the BE work. I can hide the option for now I guess?

deansheather
deansheather approved these changes May 27, 2022
View reviewed changes
coderd/users_test.go Show resolved Hide resolved
site/src/api/api.ts Outdated Show resolved Hide resolved
@tjcran tjcran added this to the Community MVP milestone May 30, 2022
@Emyrk
change 'active' route to 'activate'
df96f3d 
- Remove "activate" button
@Emyrk Emyrk merged commit 26a2a16 into main May 31, 2022
@Emyrk Emyrk deleted the stevenmasley/suspended_users branch May 31, 2022 13:06
@Emyrk Emyrk mentioned this pull request May 31, 2022
Closed
@Emyrk Emyrk mentioned this pull request May 31, 2022
Closed
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@Emyrk @kylecarbs
fix: Suspended users cannot authenticate (#1849)
13f5c75 
* fix: Suspended users cannot authenticate

- Merge roles and apikey extract httpmw
- Add member account to make dev
- feat: UI Shows suspended error logging into suspended account
- change 'active' route to 'activate'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs left review comments

@deansheather deansheather deansheather approved these changes

@greyscaled greyscaled Awaiting requested review from greyscaled

Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
Community MVP
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Emyrk @kylecarbs @deansheather @misskniss @tjcran