Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(site): username validation in forms #1851

Merged
merged 2 commits into from
May 27, 2022
Merged

fix(site): username validation in forms #1851

merged 2 commits into from
May 27, 2022

Conversation

oxy
Copy link
Contributor

@oxy oxy commented May 27, 2022

This PR refactors name validation and moves it to util/formUtils.ts and adds validation to the username field in CreateUserForm and SettingsAccountForm

Subtasks

Fixes #1693

@oxy oxy requested a review from a team as a code owner May 27, 2022 16:39
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heck ya! looks great :)

@oxy oxy enabled auto-merge (squash) May 27, 2022 16:54
@oxy oxy merged commit 14cdd85 into main May 27, 2022
@oxy oxy deleted the oxy/fe-name-validate branch May 27, 2022 17:02
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
* refactor(site): move name validation to utils
* fix(site): username validation in forms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: FE presents undetailed error message for username validation
3 participants