Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user password change page #1866

Merged
merged 3 commits into from
May 27, 2022
Merged

feat: add user password change page #1866

merged 3 commits into from
May 27, 2022

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented May 27, 2022

This adds a "Security" page with the form to change your password.

Closes #1819

@f0ssel f0ssel marked this pull request as ready for review May 27, 2022 21:44
@f0ssel f0ssel requested a review from a team as a code owner May 27, 2022 21:44
@f0ssel f0ssel enabled auto-merge (squash) May 27, 2022 21:50
@f0ssel f0ssel requested a review from greyscaled May 27, 2022 21:50
export const updateUserPassword = async (password: string, userId: TypesGen.User["id"]): Promise<undefined> =>
axios.put(`/api/v2/users/${userId}/password`, { password })
export const updateUserPassword = async (
userId: TypesGen.User["id"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise: Nice typing!

})

export type SecurityFormErrors = FormikErrors<SecurityFormValues>
export interface SecurityFormProps {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export interface SecurityFormProps {
export interface SecurityFormProps {

@f0ssel f0ssel merged commit 8222bdc into main May 27, 2022
@f0ssel f0ssel deleted the f0ssel/user-pass-fe branch May 27, 2022 22:08
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: User cannot choose password
2 participants