Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: coderd: dev mode should show verbose output by default #1898

Merged
merged 2 commits into from
Jun 1, 2022

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented May 30, 2022

This fixes a pet peeve of mine -- development mode should show verbose output by default.

EDIT: Per Kyle's suggestion, only doing this if buildmode is dev.

@johnstcn johnstcn requested a review from a team May 30, 2022 11:44
@kylecarbs
Copy link
Member

--dev is our primary funnel for users trying Coder, so I'm not sure we want to have verbose output by default. We could enable verbose if the buildmode is dev!

@johnstcn johnstcn self-assigned this May 30, 2022
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach! 👍🏻

@johnstcn johnstcn merged commit 7b40c69 into main Jun 1, 2022
@johnstcn johnstcn deleted the cj/dev-verbose branch June 1, 2022 10:00
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
* check buildinfo for devel prerelease tag and show verbose output if so
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants