Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set traffic tag to commit hash #190

Merged
merged 5 commits into from
Feb 8, 2022
Merged

chore: set traffic tag to commit hash #190

merged 5 commits into from
Feb 8, 2022

Conversation

jawnsy
Copy link
Contributor

@jawnsy jawnsy commented Feb 8, 2022

No description provided.

@jawnsy jawnsy self-assigned this Feb 8, 2022
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #190 (9fb4f63) into main (7851067) will increase coverage by 3.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
+ Coverage   64.66%   68.01%   +3.35%     
==========================================
  Files          58      108      +50     
  Lines         648     5631    +4983     
  Branches       68       68              
==========================================
+ Hits          419     3830    +3411     
- Misses        217     1438    +1221     
- Partials       12      363     +351     
Flag Coverage Δ
unittest-go-macos-latest 65.55% <ø> (?)
unittest-go-ubuntu-latest 66.96% <ø> (?)
unittest-go-windows-latest 65.64% <ø> (?)
unittest-js 64.66% <ø> (ø)
Impacted Files Coverage Δ
coderd/userpassword/userpassword.go 63.41% <0.00%> (ø)
httpmw/userparam.go 76.66% <0.00%> (ø)
provisioner/terraform/provision.go 75.69% <0.00%> (ø)
httpmw/projectparam.go 76.47% <0.00%> (ø)
database/db.go 0.00% <0.00%> (ø)
peer/channel.go 84.75% <0.00%> (ø)
provisionersdk/transport.go 55.31% <0.00%> (ø)
peerbroker/dial.go 76.19% <0.00%> (ø)
database/postgres/postgres.go 70.73% <0.00%> (ø)
database/pubsub.go 77.08% <0.00%> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7851067...9fb4f63. Read the comment docs.

@@ -222,7 +222,7 @@ jobs:
- run: docker push us-docker.pkg.dev/coder-blacktriangle-dev/ci/coder:latest

- name: Update coder service
run: gcloud run services update coder --image us-docker.pkg.dev/coder-blacktriangle-dev/ci/coder:latest --project coder-blacktriangle-dev --region us-central1
run: gcloud run services update coder --image us-docker.pkg.dev/coder-blacktriangle-dev/ci/coder:latest --project coder-blacktriangle-dev --tag="${{ github.sha }}" --region us-central1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat idea 👍

@jawnsy jawnsy marked this pull request as ready for review February 8, 2022 00:46
@jawnsy jawnsy merged commit 3903408 into main Feb 8, 2022
@jawnsy jawnsy deleted the jawnsy/add-commit-tag branch February 8, 2022 00:50
@jawnsy jawnsy removed their assignment Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants