Remove set -u on yarn_install.sh to allow it to run on macos default bash #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spike Curtis <spike@coder.com>
|
The script is using bash as it has the bang at the top. Interesting that there's differences between the two OS's bash installs |
deansheather
approved these changes
May 31, 2022
|
Looks like this is caused by an old bash version. The behavior changed in bash-4.4, but my Mac is still on version 3.2.57. |
spikecurtis
changed the title
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
Signed-off-by: Spike Curtis <spike@coder.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On zsh (default on macos) yarn_install.sh fails like:
It seems that zsh is refusing to expand an empty array with
set -uenabled, while bash happily does so. We could add an explicit if test, but that seems complex for such a short script.