New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: display error message from backend on Users page #1938

Merged

presleyp merged 1 commit into main from role-error/presleyp/1932

Jun 1, 2022

Contributor

presleyp commented Jun 1, 2022

Fixes #1932
I went ahead and fixed it for all the errors in this XService, but let me know if any shouldn't work this way for any reason @Emyrk


          Use backend error if possible

b6d784b

presleyp requested a review from a team as a code owner

June 1, 2022 01:29

kylecarbs approved these changes

View reviewed changes

Member

kylecarbs left a comment

Neato. I like how getErrorMessage is implemented. It's nice and separated from the API layer 😎

presleyp merged commit 2878346 into main

presleyp deleted the role-error/presleyp/1932 branch

June 1, 2022 13:10

kylecarbs pushed a commit that referenced this pull request


          Use backend error if possible (#1938)

c4dbcf5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment