Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for --identity-agent in coder ssh #1954

Merged
merged 1 commit into from
Jun 2, 2022
Merged

feat: Add support for --identity-agent in coder ssh #1954

merged 1 commit into from
Jun 2, 2022

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Jun 1, 2022

This PR adds support for --identity-agent or CODER_SSH_IDENTITY_AGENT, which overrides SSH_AUTH_SOCK.

Fixes #1887

@mafredri mafredri self-assigned this Jun 1, 2022
@mafredri mafredri requested a review from a team June 1, 2022 16:56
Emyrk
Emyrk approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the use case, but code LG.

johnstcn
johnstcn approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember the last time I needed to juggle multiple identity agents, but I'm sure the ability is useful.

@mafredri mafredri merged commit 51c420c into main Jun 2, 2022
@mafredri mafredri deleted the mafredri/cli-add-ssh-identity-agent-flag branch June 2, 2022 08:13
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@mafredri @kylecarbs
feat: Add support for --identity-agent in coder ssh (#1954)
e7a1c7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@Emyrk Emyrk Emyrk approved these changes

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Add flag and env variable for identity agent in coder ssh
4 participants
@mafredri @johnstcn @Emyrk @kylecarbs