fix: Avoid use of r.Context() after r.Hijack() #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
commented
Jun 2, 2022
mafredri
commented
Jun 2, 2022
deansheather
approved these changes
Jun 2, 2022
|
An absolutely awesome fix @mafredri! |
mafredri
force-pushed
the
mafredri/fix-goroutine-leak
branch
from
3f8c815
to
9e6727e
Compare
johnstcn
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how we initialize
websocket.NetConns so that we have a context that emits connection closure.Fixes #1508
This is version 2. Initially I implemented
io.EOFclosure propagation incoderd/turnconn.Conn, while I do think it may be a good idea, it's not necessary to fix #1508. I implemented it this way so that the fix can be utilized in the other handlers as well.