feat: ui autostop extension #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: #1460 Summary: An 'Extend' CTA on workspace schedule banner is added so that a user can extend their workspace lease from the UI. Details: * feat: putWorkspaceExtension handler * refactor: TypesGen dflt import in workspace.ts * feat: defaultWorkspaceExtension util Impact: This completes the UI<-->CLI parity epic in an MVP way. Of course, a future improvement to make is extending by times other than the default 90 minutes.
greyscaled
commented
Jun 2, 2022
site/src/components/WorkspaceScheduleBanner/WorkspaceScheduleBanner.tsx
Outdated
Show resolved
Hide resolved
Kira-Pilot
reviewed
Jun 2, 2022
site/src/components/WorkspaceScheduleBanner/WorkspaceScheduleBanner.tsx
Outdated
Show resolved
Hide resolved
Kira-Pilot
reviewed
Jun 2, 2022
site/src/components/WorkspaceScheduleBanner/WorkspaceScheduleBanner.tsx
Outdated
Show resolved
Hide resolved
Kira-Pilot
reviewed
Jun 2, 2022
site/src/components/WorkspaceScheduleBanner/WorkspaceScheduleBanner.tsx
Outdated
Show resolved
Hide resolved
Kira-Pilot
approved these changes
Jun 2, 2022
Renamed to reduce collision/overlap with the component name
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
Resolves: #1460 Summary: An 'Extend' CTA on workspace schedule banner is added so that a user can extend their workspace lease from the UI. Details: * feat: putWorkspaceExtension handler * refactor: TypesGen dflt import in workspace.ts * feat: defaultWorkspaceExtension util Impact: This completes the UI<-->CLI parity epic in an MVP way. Of course, a future improvement to make is extending by times other than the default 90 minutes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1460
Summary:
An 'Extend' CTA on workspace schedule banner is added so that a user can
extend their workspace lease from the UI.
Details:
feat: putWorkspaceExtension handler
refactor: TypesGen dflt import in workspace.ts
feat: defaultWorkspaceExtension util
Impact:
This completes the UI<-->CLI parity epic in an MVP way. Of course, a
future improvement to make is extending by times other than the default
90 minutes.
Demo
I'll make a GIF demo later
Machine