Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update stale.yml to only apply to pulls, not issues #200

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

bryphe-coder
Copy link
Contributor

Since we're using GH issues to track work (thanks @misskniss and @tjcran for setting this up!) - we probably don't want the stale bot to close untouched issues every month 😬

I considered using a separate stale-duration (like, 365 days for issues) - but just turned it off now. Easy for us to change if we want to adjust the process.

Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wise change!

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #200 (4427d5c) into main (78bf4c6) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   68.32%   68.27%   -0.05%     
==========================================
  Files         111      111              
  Lines        6004     6004              
  Branches       68       68              
==========================================
- Hits         4102     4099       -3     
- Misses       1513     1515       +2     
- Partials      389      390       +1     
Flag Coverage Δ
unittest-go-macos-latest 66.25% <ø> (-0.03%) ⬇️
unittest-go-ubuntu-latest 67.40% <ø> (-0.34%) ⬇️
unittest-go-windows-latest 66.05% <ø> (-0.09%) ⬇️
unittest-js 64.66% <ø> (ø)
Impacted Files Coverage Δ
peer/conn.go 78.97% <0.00%> (-1.54%) ⬇️
provisionerd/provisionerd.go 69.51% <0.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78bf4c6...4427d5c. Read the comment docs.

@bryphe-coder
Copy link
Contributor Author

Thanks @kylecarbs and @vapurrmaid for the incredibly fast review ⚡

@bryphe-coder bryphe-coder merged commit d379767 into main Feb 9, 2022
@bryphe-coder bryphe-coder deleted the bryphe/chore/dont-stale-issues branch February 9, 2022 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants