Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update success confirmation dialog and snackbar #2005

Merged
merged 4 commits into from
Jun 3, 2022

Conversation

AbhineetJain
Copy link
Contributor

@AbhineetJain AbhineetJain commented Jun 2, 2022

This PR updates the UI for success confirmation dialog and snackbar.

Subtasks

  • add the UI for success confirmation dialog
  • add the UI for success snackbar
  • update the UI for info to be consistent with error and success
  • update and add corresponding stories
  • update the usages of snackbar and confirm dialog to success type wherever applicable.

Fixes #1984

Screenshots

Success snackbar

Screen Shot 2022-06-03 at 11 24 00 AM

Info snackbar

Screen Shot 2022-06-03 at 11 24 16 AM

Info confirm dialogs

Screen Shot 2022-06-03 at 11 26 39 AM
Screen Shot 2022-06-03 at 11 23 37 AM

Success confirm dialogs

Screen Shot 2022-06-03 at 11 23 52 AM

Screen Shot 2022-06-03 at 11 23 44 AM

@AbhineetJain AbhineetJain marked this pull request as ready for review June 3, 2022 15:08
@AbhineetJain AbhineetJain requested a review from a team as a code owner June 3, 2022 15:08
@AbhineetJain
Copy link
Contributor Author

I have the following observations from the code:

  • There are no usages of an info type Snackbar, so all of the previous info type snackbars will now use the success type.
  • There are no success or info type ConfirmDialog, only delete types. Expecting no changes to confirm dialogs.

I might be wrong, so it'd be great if someone can help me understand if I missed something.

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!!! 👍

@AbhineetJain AbhineetJain merged commit 2b12bee into main Jun 3, 2022
@AbhineetJain AbhineetJain deleted the abhineetjain/1984-success-dialog-alert branch June 3, 2022 15:42
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
* feat: update success confirmation dialog and snackbar

* add success variants to confirm dialog and snackbar

* update story name

* use success variant for snackbar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX: Update UI for the Confirmation dialog and success alert using the green color
2 participants