Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor site to improve testing #2014

Merged
merged 1 commit into from
Jun 3, 2022
Merged

chore: Refactor site to improve testing #2014

merged 1 commit into from
Jun 3, 2022

Conversation

kylecarbs
Copy link
Member

It was difficult to develop this package due to the
embed build tag being mandatory on the tests. The logic
to test doesn't require any embedded files.

It was difficult to develop this package due to the
embed build tag being mandatory on the tests. The logic
to test doesn't require any embedded files.
@kylecarbs kylecarbs self-assigned this Jun 3, 2022
@kylecarbs kylecarbs requested a review from a team as a code owner June 3, 2022 04:08
@kylecarbs kylecarbs enabled auto-merge (squash) June 3, 2022 04:21
@kylecarbs kylecarbs merged commit 61aacff into main Jun 3, 2022
@kylecarbs kylecarbs deleted the refactorsite branch June 3, 2022 04:27
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

kylecarbs added a commit that referenced this pull request Jun 10, 2022
It was difficult to develop this package due to the
embed build tag being mandatory on the tests. The logic
to test doesn't require any embedded files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants