Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ws schedule timezone select #2032

Merged
merged 3 commits into from
Jun 3, 2022
Merged

Conversation

greyscaled
Copy link
Contributor

Resolves: #1959

Summary:

The package tzdata is used to create a meaningful select-list for
timezone in the workspace schedule form.

Impact:

Improved UX. Furthermore, we guess your timezone if the form is being
initialized from scratch.

Resolves: #1959

Summary:

The package tzdata is used to create a meaningful select-list for
timezone in the workspace schedule form.

Impact:

Improved UX. Furthermore, we guess your timezone if the form is being
initialized from scratch.
@greyscaled greyscaled self-assigned this Jun 3, 2022
@greyscaled greyscaled requested a review from a team as a code owner June 3, 2022 16:13
@greyscaled greyscaled requested a review from johnstcn June 3, 2022 16:14
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BE = 👍

Loving that drop-down list

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!!!

@greyscaled greyscaled merged commit ac6cb26 into main Jun 3, 2022
@greyscaled greyscaled deleted the vapurrmaid/gh-1959/tzdata branch June 3, 2022 16:52
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
Resolves: #1959

Summary:

The package tzdata is used to create a meaningful select-list for
timezone in the workspace schedule form.

Impact:

Improved UX. Furthermore, we guess your timezone if the form is being
initialized from scratch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX: Schedule timezone should be a select list
3 participants