Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use ConfirmDialog for ResetPasswordDialog #2035

Merged
merged 5 commits into from
Jun 3, 2022

Conversation

AbhineetJain
Copy link
Contributor

@AbhineetJain AbhineetJain commented Jun 3, 2022

This PR updates the styles for ResetPassword Dialog box to the same as ConfirmDialog info style.

Subtasks

  • use ConfirmDialog component for ResetPasswordDialog
  • use CodeExample instead of CodeBlock
  • fix unit tests

Screenshot

Screen Shot 2022-06-03 at 12 39 48 PM

Fixes #2034

@AbhineetJain AbhineetJain requested a review from a team as a code owner June 3, 2022 16:40
@greyscaled
Copy link
Contributor

This looks great, ready to approve once the tests are updated. Nice one 🙌🏻

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks like the tests are failing.

@AbhineetJain AbhineetJain enabled auto-merge (squash) June 3, 2022 17:29
@AbhineetJain AbhineetJain merged commit fc38b61 into main Jun 3, 2022
@AbhineetJain AbhineetJain deleted the abhineetjain/2034-update-reset-password branch June 3, 2022 17:35
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
* feat: use ConfirmDialog for ResetPasswordDialog

* fix lint

* make description typography a div

* use paragraph for string description, div otherwise

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conform ResetPasswordDialog design with ConfirmDialog
3 participants