feat: Authenticate Digital Ocean via environment variable #2051
Conversation
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
|
Cleanly written 👍 |
| This template assumes that coderd is run in an environment that is authenticated | ||
| with Google Cloud. For example, run `gcloud auth application-default login` to import |
There was a problem hiding this comment.
I think calling it coderd is unclear in this case. This was the name for the Coder binary in Coder Classic, but we don't refer to it as coderd in the user-facing product UI or documentation. I'd suggest calling it the "Coder host"
I did notice the code refers to it as "coderd"
Would like your thoughts though. We can merge and reconsider later.
There was a problem hiding this comment.
We need a consistent set of terms for various components of the project / solution, and for v1 stuff moving forward (are we calling this "Coder Classic"!?). Perhaps you and I can collaborate on a RFC to this effect and get some more input.
It's really a drag to have different internal and external names down at the component level. Engineers will naturally screw up terminology in documents, customer interactions, etc. So, there has to be a really strong case for naming these things differently.
* Digital Ocean example uses environment variable auth Signed-off-by: Spike Curtis <spike@coder.com>
Second PR addressing #1967
Still need K8s to call it done.