Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add links to the resource card for workspace applications #2067

Merged
merged 3 commits into from Jun 6, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Jun 6, 2022

Fixes #1907 and #805.

I'll make this pretty in another PR!

image
This error screen is displayed when an application isn't reachable.

This was broken when improving the build times. The typechecker
unfortunately missed it!
Fixes #1907 and #805.

I'll make this pretty in another PR!
@kylecarbs kylecarbs requested a review from a team as a code owner June 6, 2022 01:57
@kylecarbs kylecarbs self-assigned this Jun 6, 2022
userName={workspace.owner_name}
workspaceName={workspace.name}
/>
))}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would wrap these insides of a Stack to add some spacing between the items inside of this column. I would also add a default icon or a left margin if it does not have one to be aligned with the terminal to avoid the situation below:

Screen Shot 2022-06-06 at 10 39 41

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, just a minor observation related to the design.

@kylecarbs kylecarbs merged commit ab8235f into main Jun 6, 2022
@kylecarbs kylecarbs deleted the appui branch June 6, 2022 14:50
kylecarbs added a commit that referenced this pull request Jun 10, 2022
* fix: Use proper webpack config for dev mode

This was broken when improving the build times. The typechecker
unfortunately missed it!

* feat: Add links to the resource card for workspace applications

Fixes #1907 and #805.

I'll make this pretty in another PR!

* Improve style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add error metadata to index.html to forward backend errors
2 participants