Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add page titles #2070

Merged
merged 1 commit into from Jun 6, 2022
Merged

feat: Add page titles #2070

merged 1 commit into from Jun 6, 2022

Conversation

kylecarbs
Copy link
Member

Fixes #2069.

This adds titles to every page! I considered making a Page wrapper but decided against it for the fear of premature abstraction. This seems simple enough for now!

The delimitation is inspired by GitHub, namely the ·.

@kylecarbs kylecarbs self-assigned this Jun 6, 2022
@kylecarbs kylecarbs requested a review from a team as a code owner June 6, 2022 02:44
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kylecarbs kylecarbs merged commit 0ac37b1 into main Jun 6, 2022
@kylecarbs kylecarbs deleted the titles branch June 6, 2022 13:34
kylecarbs added a commit that referenced this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add page titles
2 participants