chore: version sub command remove --version and -v flag

[Emyrk]

What this does (#1543)

Removes coder -v and coder --version.

Now do coder version to see coder version.

$ coder version
Coder v0.0.0-devel+ae779c6 Mon Jun  6 15:18:00 UTC 2022
https://github.com/coder/coder/commit/ae779c6276a5f305273343c3d5d4836d6a16c890

[mafredri]

Thanks for picking this one up! 👍🏻

[mafredri]

Suggestion: I think this reads a bit better, but up to you to include or not.

Suggested change

	Short: "Version for coder",
	Short: "Show coder version",

[kylecarbs]

Cobra doesn't add this flag if Version isn't specified in the root. I'd propose that being a cleaner alternative.

Having --version and coder version seems unnecessary to me. I'd prefer to have coder version.

[mafredri]

I’m fine with only having version but having both is consistent with help (or do I misremember?) and I think covers a common use case. I.e. there’s a 50/50 chance someone will blindly do either --version or version instead of checking help 😄.

[kylecarbs]

I like how Go just does go version. I haven't found it to be confusing tbh

[Emyrk]

Correct cobra does not. However if we want to support --version, we would need a persistent pre-run function to support the flag. Cobra has some first class support for --version that works even if there are extra args, eg: coder --version workspaces.

I think it is reasonable to use their first class support for this reason.

As for --version or coder version. I don't see anything wrong with supporting both. It's nice as a user to do w/e is more familiar to you.

Maybe coder version can report more info like the version of the deployment you are logged into.

Examples:

• git version & git --version
• docker --version is less verbose than docker version
• docker-compose --version is less verbose than docker-compose version

[kylecarbs]

It's fine to support both, I don't really understand why we need to though. Seems like supporting coder version is fine, and supporting both seems to not really satisfy a need, but adds an additional user-contract for us to test.

[Emyrk]

I'll drop the flag for now then and just do coder version