Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support substring search on workspace name #2096

Merged
merged 2 commits into from Jun 6, 2022
Merged

fix: support substring search on workspace name #2096

merged 2 commits into from Jun 6, 2022

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Jun 6, 2022

Fixes #2043

kylecarbs
kylecarbs approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have to adjust the databasefake to do this too! Adding a test for this would be good.

@f0ssel f0ssel enabled auto-merge (squash) June 6, 2022 19:26
@f0ssel f0ssel merged commit a860b86 into main Jun 6, 2022
@f0ssel f0ssel deleted the f0ssel/name-substring-search branch June 6, 2022 19:43
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@f0ssel @kylecarbs
fix: support substring search on workspace name (#2096)
585e16c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workspace search without classifier has confusing results
2 participants
@f0ssel @kylecarbs