Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct localhost url in dev webpack #2098

Merged
merged 1 commit into from Jun 6, 2022
Merged

fix: correct localhost url in dev webpack #2098

merged 1 commit into from Jun 6, 2022

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Jun 6, 2022 •
edited

Fixes an issue where you cannot login with make dev, introduced 0ac37b1#diff-b17823d590cbd82b7f4b0a4f646ed90083d0009fafdf34a4b4d7d24fa2750208L66

@f0ssel f0ssel requested a review from a team as a code owner June 6, 2022 18:20
@f0ssel f0ssel requested a review from kylecarbs June 6, 2022 18:21
presleyp
presleyp approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@f0ssel f0ssel enabled auto-merge (squash) June 6, 2022 18:27
@f0ssel f0ssel merged commit 1a39931 into main Jun 6, 2022
@f0ssel f0ssel deleted the f0ssel/fix-webpack-dev branch June 6, 2022 18:38
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@f0ssel @kylecarbs
fix: correct localhost url in dev webpack (#2098)
c26f8c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@presleyp presleyp presleyp approved these changes

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@f0ssel @presleyp @kylecarbs