fix: Make the workspace URL pretty #2101
Conversation
|
I think it's important for the user to have a cue about which page they're on (that underline we used to have). Here's the docs on it https://v5.reactrouter.com/web/api/NavLink, you probably have to update |
|
@presleyp indeed! That is the problem... I'll investigate a bit. |
|
@kylecarbs but yeah I see your point, maybe it shouldn't say you're on the workspaces page when you're on the workspace page. Not sure what's typical there! |
|
I think it makes more sense, so I'll make the change! |
|
@f0ssel want to make sure you're happy with the solution |
This adds the `@username/workspacename` format to the workspace page!
|
Going to merge for now. @f0ssel and I chatted a while back and he seemed to be good with this route, but please comment if I'm mistaken! |
This was broken as part of #2101. It was a silly mistake, but unfortunate our tests didn't catch it. This is a rare change so unlikely to occur again, so I won't make an issue adding tests.
| @@ -63,7 +63,7 @@ const config: Configuration = { | |||
| port: process.env.PORT || 8080, | |||
| proxy: { | |||
| "/api": { | |||
| target: "http://localhost:3000", | |||
| target: "https://dev.coder.com", | |||
There was a problem hiding this comment.
@kylecarbs Is this an expected change? Broke my local development dummy login creds.
There was a problem hiding this comment.
I'm going to make this a flag so this never gets in again!
|
I also found that redirection after creating a new workspace via the UI is broken. I am assuming we missed updating that URL in this PR. |
|
Ahh yes. I'll fix that in my other PR for schedules, feel free to review that! |
This was broken as part of #2101. It was a silly mistake, but unfortunate our tests didn't catch it. This is a rare change so unlikely to occur again, so I won't make an issue adding tests.
This was broken as part of #2101. It was a silly mistake, but unfortunate our tests didn't catch it. This is a rare change so unlikely to occur again, so I won't make an issue adding tests.
This was broken as part of #2101. It was a silly mistake, but unfortunate our tests didn't catch it. This is a rare change so unlikely to occur again, so I won't make an issue adding tests.
* fix: Update routing for workspace schedule This was broken as part of #2101. It was a silly mistake, but unfortunate our tests didn't catch it. This is a rare change so unlikely to occur again, so I won't make an issue adding tests. * Update site/src/pages/WorkspaceSchedulePage/WorkspaceSchedulePage.tsx Co-authored-by: Presley Pizzo <1290996+presleyp@users.noreply.github.com> Co-authored-by: Presley Pizzo <1290996+presleyp@users.noreply.github.com>
This adds the `@username/workspacename` format to the workspace page!
* fix: Update routing for workspace schedule This was broken as part of #2101. It was a silly mistake, but unfortunate our tests didn't catch it. This is a rare change so unlikely to occur again, so I won't make an issue adding tests. * Update site/src/pages/WorkspaceSchedulePage/WorkspaceSchedulePage.tsx Co-authored-by: Presley Pizzo <1290996+presleyp@users.noreply.github.com> Co-authored-by: Presley Pizzo <1290996+presleyp@users.noreply.github.com>
This adds the
@username/workspacenameformat to theworkspace page!
The only oddity I've noticed is no underline for
Workspacesanymore, but I'm not sure whether it should have been anyways!