Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added include_deleted to getWorkspaceByOwnerAndName #2164
feat: added include_deleted to getWorkspaceByOwnerAndName #2164
Changes from 1 commit
142ad4e
5c77ea4
31f4013
9389df3
769ea99
f8a844c
56bceb6
ee1f417
28c2db6
5381554
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this works as intended. The param here in the SQL matches for
deleted = $includeDeleted
.So if you set this to true, the workspace will not show if the workspace is deleted. We will need to update the SQL too, or just always return deleted workspaces by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See how it's handled here:
coder/coderd/workspaces.go
Lines 57 to 62 in 454aea7
I think the
deleted
query param is kinda annoying as you have to know the state of the workspace to query it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Emyrk Hmm, testing it in the UI seems to work.
include_deleted
is false, then we never enter this code block (becauseerrors.Is(err, sql.ErrNoRows)
is falseIn either case, if we get nothing back, we then go into the
httpapi.Forbidden(rw)
block below. I agree editing the SQL would also work. I just didn't know what other ramifications that would have.Let me know if I'm misunderstanding your comment!