Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Login - Add padding between username / password #239

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

bryphe-coder
Copy link
Contributor

This is just a minor fit & finish fix for login, to more closely emulate the styling of v1.

Before:
Screen Shot 2022-02-09 at 4 16 05 PM

After:
Screen Shot 2022-02-09 at 4 13 34 PM

While I was looking at this - removed a few currently-unnecessary styles and added a story for this component.

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #239 (df359af) into main (b6fcd81) will increase coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
+ Coverage   67.93%   68.24%   +0.31%     
==========================================
  Files         111      111              
  Lines        6003     6003              
  Branches       67       67              
==========================================
+ Hits         4078     4097      +19     
+ Misses       1531     1516      -15     
+ Partials      394      390       -4     
Flag Coverage Δ
unittest-go-macos-latest 66.17% <ø> (?)
unittest-go-ubuntu-latest 67.40% <ø> (-0.04%) ⬇️
unittest-go-windows-latest 65.91% <ø> (+0.02%) ⬆️
unittest-js 64.76% <ø> (ø)
Impacted Files Coverage Δ
site/components/SignIn/SignInForm.tsx 100.00% <ø> (ø)
peerbroker/dial.go 76.19% <0.00%> (-4.77%) ⬇️
database/pubsub.go 75.00% <0.00%> (-2.09%) ⬇️
peerbroker/listen.go 84.80% <0.00%> (+2.39%) ⬆️
peer/conn.go 79.74% <0.00%> (+5.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6fcd81...df359af. Read the comment docs.

@bryphe-coder bryphe-coder self-assigned this Feb 10, 2022
@bryphe-coder bryphe-coder merged commit 277318b into main Feb 10, 2022
@bryphe-coder bryphe-coder deleted the bryphe/fix/sign-in-styling branch February 10, 2022 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants