Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove 'Create Project' button, replace with CLI prompt #245

Merged
merged 4 commits into from
Feb 11, 2022

Conversation

bryphe-coder
Copy link
Contributor

For black-triangle and alpha builds, we won't be able to create projects in the UI, because they require collecting and tar'ing a set of assets associated with the project - so the CLI is going to be our entry point for creating projects.

This shifts the UI to remove the 'Create Project' button, and adds a prompt to copy a command to run.

Before:
image

After:
2022-02-10 19 38 01

@bryphe-coder bryphe-coder self-assigned this Feb 11, 2022
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neato

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #245 (5f683ea) into main (a82fb8f) will decrease coverage by 0.08%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
- Coverage   67.31%   67.23%   -0.09%     
==========================================
  Files         120      124       +4     
  Lines        6484     6516      +32     
  Branches       67       69       +2     
==========================================
+ Hits         4365     4381      +16     
- Misses       1701     1714      +13     
- Partials      418      421       +3     
Flag Coverage Δ
unittest-go-macos-latest 65.13% <ø> (-0.23%) ⬇️
unittest-go-ubuntu-latest 66.43% <ø> (-0.12%) ⬇️
unittest-go-windows-latest 66.28% <ø> (+0.13%) ⬆️
unittest-js 65.24% <62.50%> (+0.48%) ⬆️
Impacted Files Coverage Δ
site/components/CodeExample/index.ts 0.00% <0.00%> (ø)
site/pages/projects/index.tsx 0.00% <0.00%> (ø)
site/theme/palettes.ts 100.00% <ø> (ø)
site/components/Button/CopyButton.tsx 52.38% <52.38%> (ø)
site/components/Button/index.ts 100.00% <100.00%> (ø)
site/components/CodeBlock/index.tsx 100.00% <100.00%> (ø)
site/components/CodeExample/CodeExample.tsx 100.00% <100.00%> (ø)
site/components/Icons/FileCopy.tsx 100.00% <100.00%> (ø)
site/components/Icons/index.ts 100.00% <100.00%> (ø)
peer/conn.go 80.25% <0.00%> (-1.29%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a82fb8f...5f683ea. Read the comment docs.

@bryphe-coder bryphe-coder merged commit df13fef into main Feb 11, 2022
@bryphe-coder bryphe-coder deleted the bryphe/fix/project-create-cli branch February 11, 2022 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants