Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename 'expect' package to 'console' #297

Merged
merged 4 commits into from
Feb 16, 2022

Conversation

bryphe-coder
Copy link
Contributor

@bryphe-coder bryphe-coder commented Feb 15, 2022

Fixes #291 - renames the expect go package to console, and changes the api from expect.NewTestConsole to console.New, and a few other small changes to support the linter (ie, ConsoleOpts -> Opts)

@bryphe-coder bryphe-coder self-assigned this Feb 15, 2022
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #297 (3604bef) into main (a86f2ee) will decrease coverage by 0.05%.
The diff coverage is 73.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
- Coverage   67.91%   67.86%   -0.06%     
==========================================
  Files         130      130              
  Lines        7079     7079              
  Branches       69       69              
==========================================
- Hits         4808     4804       -4     
- Misses       1781     1785       +4     
  Partials      490      490              
Flag Coverage Δ
unittest-go-macos-latest 66.01% <73.68%> (+0.01%) ⬆️
unittest-go-ubuntu-latest 67.37% <73.68%> (+0.12%) ⬆️
unittest-go-windows-latest 65.96% <73.68%> (-0.14%) ⬇️
unittest-js 65.24% <ø> (ø)
Impacted Files Coverage Δ
console/test_console.go 0.00% <0.00%> (ø)
console/console.go 66.12% <60.00%> (ø)
console/expect.go 60.37% <100.00%> (ø)
console/expect_opt.go 72.00% <100.00%> (ø)
peer/conn.go 77.17% <0.00%> (-2.57%) ⬇️
coderd/provisionerdaemons.go 57.84% <0.00%> (+0.61%) ⬆️
peerbroker/listen.go 84.80% <0.00%> (+2.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a86f2ee...3604bef. Read the comment docs.

@bryphe-coder bryphe-coder marked this pull request as ready for review February 15, 2022 23:11
@bryphe-coder bryphe-coder force-pushed the bryphe/refactor/291/expect-console branch from 2517319 to 1a7393b Compare February 15, 2022 23:15
@bryphe-coder bryphe-coder merged commit 6009c90 into main Feb 16, 2022
@bryphe-coder bryphe-coder deleted the bryphe/refactor/291/expect-console branch February 16, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "expect" package to "console"
3 participants