fix: Redirect to '?redirect' query parameter after successful login #307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #304
Unblocks #298
After logging in, the login flow should redirect to a whatever path is specified by the
?redirect
query parameter. This is important for cases like #298 - where we need to set?redirect=%2Fcli_auth
, but also really any case where the user is linked and might have to go back to the login screen.The fix is simple - just check if the
redirect
query parameter is set, and if it is, use that as the path to redirect to on success. Also adds a test case - we had one checking that we redirect to the default (root/
) url, but not one of the?redirect
param