fix: Hydration warnings / mismatched styles due to SSR #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #31 +/- ##
==========================================
- Coverage 69.26% 68.94% -0.33%
==========================================
Files 40 41 +1
Lines 1630 1642 +12
Branches 7 9 +2
==========================================
+ Hits 1129 1132 +3
- Misses 396 406 +10
+ Partials 105 104 -1
Continue to review full report at Codecov.
|
kylecarbs
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While starting on the create workspace flow - I noticed some weird CSS issues.
In particular, intermittently, the web UI would render like this:
...and when that happened, there'd be an accompanying error in the console:
The issue is that NextJS is trying to render the page on the server and use the styles - and sometimes the classnames mismatch between server-side and client-side rendering. We actually worked around this in
cdr/mwith a<SafeHydration />component and a custom_document.tsxThis change ports over both the component and custom
_document.tsx. I noticed, in addition, I missed the favicons when switching to NextJS, so I brought those over too.