Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Install terraform in Docker image to unblock deploy #319

Merged
merged 3 commits into from
Feb 18, 2022

Conversation

bryphe-coder
Copy link
Contributor

@bryphe-coder bryphe-coder commented Feb 18, 2022

Fixes #287 and re-enables our deploy at https://proto.cdr.dev

  • Installs terraform in our images/coder/Dockerfile
  • Re-enables our deploy GH action

Example of successful deploy run: https://github.com/coder/coder/runs/5241614008?check_suite_focus=true

TODO:

  • Fix if: condition when deploy is green again

@bryphe-coder bryphe-coder marked this pull request as draft February 18, 2022 01:06
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #319 (c0a8f8a) into main (e5db936) will increase coverage by 2.88%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   64.81%   67.69%   +2.88%     
==========================================
  Files          67      138      +71     
  Lines         756     7256    +6500     
  Branches       74       74              
==========================================
+ Hits          490     4912    +4422     
- Misses        251     1841    +1590     
- Partials       15      503     +488     
Flag Coverage Δ
unittest-go-macos-latest 66.44% <ø> (?)
unittest-go-ubuntu-latest 67.44% <ø> (?)
unittest-go-windows-latest 65.97% <ø> (?)
unittest-js 64.81% <ø> (ø)
Impacted Files Coverage Δ
coderd/projectversion.go 55.22% <0.00%> (ø)
codersdk/provisioners.go 63.15% <0.00%> (ø)
pty/ptytest/ptytest.go 89.79% <0.00%> (ø)
database/postgres/postgres.go 70.73% <0.00%> (ø)
database/db.go 0.00% <0.00%> (ø)
provisioner/terraform/provision.go 71.62% <0.00%> (ø)
httpmw/projectversionparam.go 72.50% <0.00%> (ø)
codersdk/users.go 68.96% <0.00%> (ø)
coderd/parameter/compute.go 71.85% <0.00%> (ø)
httpmw/userparam.go 76.66% <0.00%> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5db936...c0a8f8a. Read the comment docs.

@bryphe-coder bryphe-coder self-assigned this Feb 18, 2022
@bryphe-coder bryphe-coder marked this pull request as ready for review February 18, 2022 01:34
@bryphe-coder bryphe-coder merged commit 6170421 into main Feb 18, 2022
@bryphe-coder bryphe-coder deleted the bryphe/fix/287/cloud-deploy branch February 18, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud Run deploy failing due to missing 'terraform' dependency
3 participants