test: Fix race condition in provisionerd on cleanup #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These goroutines could be ran after the pipe has already been closed. I'm not certain this resolves this specific leak: https://github.com/coder/coder/runs/5249481202?check_suite_focus=true#step:7:186 ...but I find it likely.
Codecov Report
@@ Coverage Diff @@
## main #322 +/- ##
==========================================
+ Coverage 63.61% 67.46% +3.84%
==========================================
Files 69 140 +71
Lines 786 7407 +6621
Branches 77 77
==========================================
+ Hits 500 4997 +4497
- Misses 271 1900 +1629
- Partials 15 510 +495
Continue to review full report at Codecov.
|
Comment on lines
+409
to
+410
| ctx, cancelFunc := context.WithCancel(context.Background()) | ||
| t.Cleanup(cancelFunc) |
There was a problem hiding this comment.
Interesting... it's not clear to me how this will fix it, but I hope it does 🤞
It seems safe in any case, and it seems reasonable for this to be outside the func that starts the server.
There was a problem hiding this comment.
I'm not entirely sure either, but t.Cleanup certainly shouldn't be called async from my POV anyways.
bryphe-coder
approved these changes
Feb 18, 2022
|
Thanks for investigating this race, @kylecarbs ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These goroutines could be ran after the pipe has already been closed.
I'm not certain this resolves this specific leak:
https://github.com/coder/coder/runs/5249481202?check_suite_focus=true#step:7:186
...but I find it likely.