fix: Leaking yamux session after HTTP handler is closed #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #329 +/- ##
==========================================
+ Coverage 63.61% 67.45% +3.84%
==========================================
Files 69 140 +71
Lines 786 7443 +6657
Branches 77 77
==========================================
+ Hits 500 5021 +4521
- Misses 271 1910 +1639
- Partials 15 512 +497
Continue to review full report at Codecov.
|
kylecarbs
force-pushed
the
closerace
branch
2 times, most recently
from
263f17a
to
6126814
Compare
Closes #317. The httptest server cancels the context after the connection is closed, but if a connection takes a long time to close, the request would never end. This applies a context to the entire listener that cancels on test cleanup. After discussion with @bryphe-coder, reducing the parallel limit on Windows is likely to reduce failures as well.
| @@ -150,9 +150,13 @@ jobs: | |||
| terraform_wrapper: false | |||
|
|
|||
| - name: Test with Mock Database | |||
| shell: bash | |||
| env: | |||
| GOCOUNT: ${{ runner.os == 'Windows' && 3 || 5 }} | |||
| srv := httptest.NewServer(handler) | ||
| srv := httptest.NewUnstartedServer(handler) | ||
| srv.Config.BaseContext = func(_ net.Listener) context.Context { | ||
| ctx, cancelFunc := context.WithCancel(context.Background()) |
There was a problem hiding this comment.
Nice catch... It's surprising that this is necessary, but glad you found it.
There was a problem hiding this comment.
It genuinely amazed me.
bryphe-coder
approved these changes
Feb 19, 2022
There was a problem hiding this comment.
Thanks for working so hard to track these down @kylecarbs !
| @@ -122,7 +122,7 @@ jobs: | |||
| os: | |||
| - ubuntu-latest | |||
| - macos-latest | |||
| - windows-latest | |||
| - windows-2022 | |||
There was a problem hiding this comment.
Per our discussion in slack - we may want to consider bumping the cache in one of these ways:
- Adding a
-v0-parameter that we can bump to invalidate the cache - Using
matrix.osinstead ofrunner.osfor the cache here - that will usewindows-2022instead ofwindowsfor the cache key
There was a problem hiding this comment.
Ahh that's a great idea! Changing now.
kylecarbs
force-pushed
the
closerace
branch
2 times, most recently
from
2a0a153
to
6c68e41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #317. The httptest server cancels the context after the connection
is closed, but if a connection takes a long time to close, the request
would never end. This applies a context to the entire listener that cancels
on test cleanup.
After discussion with @bryphe-coder, reducing the parallel limit on
Windows is likely to reduce failures as well.