feat: add caching headers for Next.js static assets #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #330 +/- ##
==========================================
+ Coverage 63.61% 67.66% +4.05%
==========================================
Files 69 140 +71
Lines 786 7425 +6639
Branches 77 77
==========================================
+ Hits 500 5024 +4524
- Misses 271 1893 +1622
- Partials 15 508 +493
Continue to review full report at Codecov.
|
Comment on lines
+81
to
+83
| if strings.HasPrefix(request.URL.Path, "/_next/static/") { | ||
| writer.Header().Add("Cache-Control", "public, max-age=31536000, immutable") | ||
| } |
There was a problem hiding this comment.
Looks great! Thanks for bringing this over @jawnsy 👍
Comment on lines
+400
to
+402
| res, err := request(server, "/index.html") | ||
| require.NoError(t, err) | ||
| require.NoError(t, res.Body.Close()) |
bryphe-coder
approved these changes
Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default page has no caching:
Immutable cache-control for Next.js assets:
API calls not cached:
Other static content outside
_next/staticnot cached: