Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add a minimal example of a project with parameters #331

Merged
merged 4 commits into from
Feb 21, 2022

Conversation

bryphe-coder
Copy link
Contributor

Thought it'd be helpful to show a bare-bones example of a project with a parameter, along with references to the Terraform docs so developers can learn about more interesting variable types (and ways to leverage them in expressions).

With this project, we can go through the projects create flow of setting a parameter:
Screen Shot 2022-02-18 at 7 53 07 PM

@bryphe-coder bryphe-coder self-assigned this Feb 19, 2022
Comment on lines +3 to +5
variable "message" {
type = string
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kylecarbs - is there a way to set up a variable yet such that it would need to be specified at the workspace create level, as opposed to project level?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet :-( We'll have to figure out a way we wanna enable that.

@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #331 (ac0d6e0) into main (3b57619) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
- Coverage   67.49%   67.41%   -0.08%     
==========================================
  Files         142      142              
  Lines        7710     7710              
  Branches       77       77              
==========================================
- Hits         5204     5198       -6     
- Misses       1979     1983       +4     
- Partials      527      529       +2     
Flag Coverage Δ
unittest-go-macos-latest 66.27% <ø> (ø)
unittest-go-ubuntu-latest 67.28% <ø> (-0.21%) ⬇️
unittest-go-windows-2022 65.59% <ø> (-0.19%) ⬇️
unittest-js 63.61% <ø> (ø)
Impacted Files Coverage Δ
peerbroker/listen.go 82.40% <0.00%> (-2.40%) ⬇️
peer/conn.go 78.51% <0.00%> (-1.28%) ⬇️
provisionerd/provisionerd.go 69.33% <0.00%> (-0.40%) ⬇️
peer/channel.go 84.79% <0.00%> (+2.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b57619...ac0d6e0. Read the comment docs.

Comment on lines +3 to +5
variable "message" {
type = string
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet :-( We'll have to figure out a way we wanna enable that.

@bryphe-coder bryphe-coder merged commit 59ee22d into main Feb 21, 2022
@bryphe-coder bryphe-coder deleted the bryphe/refactor/project-with-params-example branch February 21, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants