Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix login from opening URLs automatically #334

Merged
merged 2 commits into from
Feb 21, 2022
Merged

test: Fix login from opening URLs automatically #334

merged 2 commits into from
Feb 21, 2022

Conversation

kylecarbs
Copy link
Member

When using VS Code's test on save, this was funny behavior 🤣.

@kylecarbs kylecarbs self-assigned this Feb 19, 2022
@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #334 (ac74c5e) into main (693f457) will increase coverage by 0.39%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
+ Coverage   67.31%   67.70%   +0.39%     
==========================================
  Files         142      142              
  Lines        7706     7710       +4     
  Branches       77       77              
==========================================
+ Hits         5187     5220      +33     
+ Misses       1986     1967      -19     
+ Partials      533      523      -10     
Flag Coverage Δ
unittest-go-macos-latest 66.51% <57.14%> (+0.41%) ⬆️
unittest-go-ubuntu-latest 67.75% <57.14%> (+0.37%) ⬆️
unittest-go-windows-2022 65.69% <57.14%> (-0.14%) ⬇️
unittest-js 63.61% <ø> (ø)
Impacted Files Coverage Δ
cli/root.go 84.61% <50.00%> (-1.00%) ⬇️
cli/login.go 55.23% <60.00%> (-5.24%) ⬇️
provisionerd/provisionerd.go 70.11% <0.00%> (+0.78%) ⬆️
coderd/provisionerdaemons.go 58.87% <0.00%> (+1.20%) ⬆️
peerbroker/listen.go 84.80% <0.00%> (+2.39%) ⬆️
peer/conn.go 81.84% <0.00%> (+6.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 693f457...ac74c5e. Read the comment docs.

When using VS Code's test on save, this was funny behavior 🤣.
Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@kylecarbs kylecarbs enabled auto-merge (squash) February 21, 2022 16:51
@kylecarbs kylecarbs merged commit 3b57619 into main Feb 21, 2022
@kylecarbs kylecarbs deleted the fixopen branch February 21, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants