Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use forked pion/ice to fix Close() race #341

Merged
merged 1 commit into from
Feb 21, 2022
Merged

fix: Use forked pion/ice to fix Close() race #341

merged 1 commit into from
Feb 21, 2022

Conversation

kylecarbs
Copy link
Member

Closes #340. A PR is upstream to fix the issue!

@kylecarbs kylecarbs self-assigned this Feb 21, 2022
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #341 (125a596) into main (0861e25) will increase coverage by 1.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
+ Coverage   66.06%   67.55%   +1.49%     
==========================================
  Files         134      142       +8     
  Lines        7098     7706     +608     
  Branches       77       77              
==========================================
+ Hits         4689     5206     +517     
- Misses       1939     1971      +32     
- Partials      470      529      +59     
Flag Coverage Δ
unittest-go-macos-latest 66.20% <ø> (-0.16%) ⬇️
unittest-go-ubuntu-latest 67.56% <ø> (?)
unittest-go-windows-2022 65.91% <ø> (?)
unittest-js 63.61% <ø> (ø)
Impacted Files Coverage Δ
peer/conn.go 76.21% <0.00%> (-2.56%) ⬇️
pty/start_windows.go 51.30% <0.00%> (ø)
provisioner/terraform/parse.go 77.77% <0.00%> (ø)
coderd/userpassword/userpassword.go 63.41% <0.00%> (ø)
pty/pty_windows.go 60.31% <0.00%> (ø)
provisioner/terraform/serve.go 68.75% <0.00%> (ø)
database/postgres/postgres.go 70.73% <0.00%> (ø)
agent/usershell/usershell_other.go 60.00% <0.00%> (ø)
provisioner/terraform/provision.go 71.62% <0.00%> (ø)
cli/login.go 60.46% <0.00%> (+0.58%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0861e25...125a596. Read the comment docs.

Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, hope this makes the tests more reliable

Closes #340. A PR is upstream to fix the issue!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix close race in pion/ice
2 participants