Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use forked pion/ice to fix Close() data race #342

Merged
merged 1 commit into from
Feb 21, 2022
Merged

fix: Use forked pion/ice to fix Close() data race #342

merged 1 commit into from
Feb 21, 2022

Conversation

kylecarbs
Copy link
Member

I introduced a data-race in my fork while fixing the close race.
This is fixed now, and contributed upstream!

I introduced a data-race in my fork while fixing the close race.
This is fixed now, and contributed upstream!
@kylecarbs kylecarbs self-assigned this Feb 21, 2022
@kylecarbs
Copy link
Member Author

Seeing "fixed" with a failed CI always gives me sad chills.
image

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #342 (2ea35ca) into main (c85933f) will increase coverage by 3.89%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
+ Coverage   63.61%   67.50%   +3.89%     
==========================================
  Files          69      142      +73     
  Lines         786     7706    +6920     
  Branches       77       77              
==========================================
+ Hits          500     5202    +4702     
- Misses        271     1975    +1704     
- Partials       15      529     +514     
Flag Coverage Δ
unittest-go-macos-latest 66.17% <ø> (?)
unittest-go-ubuntu-latest 67.59% <ø> (?)
unittest-go-windows-2022 65.87% <ø> (?)
unittest-js 63.61% <ø> (ø)
Impacted Files Coverage Δ
provisionersdk/transport.go 55.31% <0.00%> (ø)
peer/conn.go 77.23% <0.00%> (ø)
httpmw/apikey.go 84.34% <0.00%> (ø)
codersdk/projects.go 70.65% <0.00%> (ø)
pty/start_windows.go 51.30% <0.00%> (ø)
pty/pty_other.go 35.89% <0.00%> (ø)
coderd/workspaces.go 65.11% <0.00%> (ø)
cli/workspacecreate.go 47.36% <0.00%> (ø)
cli/projects.go 76.27% <0.00%> (ø)
provisionersdk/serve.go 35.13% <0.00%> (ø)
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c85933f...2ea35ca. Read the comment docs.

@kylecarbs kylecarbs merged commit 693f457 into main Feb 21, 2022
@kylecarbs kylecarbs deleted the fixice branch February 21, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants