refactor: Fix front-end lint issues #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryphe-coder
commented
Feb 21, 2022
Comment on lines
+21
to
+23
| const onCancel = useCallback(async () => { | ||
| await push(`/projects/${organization}/${projectName}`) | ||
| }, [push, organization, projectName]) |
There was a problem hiding this comment.
This had to be moved before the early-return because hooks always have to be called consistently and in a consistent order.
Codecov Report
@@ Coverage Diff @@
## main #347 +/- ##
==========================================
+ Coverage 67.64% 67.86% +0.22%
==========================================
Files 147 147
Lines 7930 7905 -25
Branches 77 72 -5
==========================================
+ Hits 5364 5365 +1
+ Misses 2023 1998 -25
+ Partials 543 542 -1
Continue to review full report at Codecov.
|
kylecarbs
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while running through the build steps (
make build) that we were getting some lint warnings that weren't blocking build:It turns out our ESLint config wasn't being picked up, so I fixed that (it wasn't properly named). This PR turns warnings-as-errors on, fixes the issues, and also removes the "Project Create" page, because it isn't used at this time.
Wanted to clean this up before on-boarding more FE developers