Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Convert all jobs to use a common resource and agent type #369

Merged
merged 14 commits into from
Feb 28, 2022
Merged

Conversation

kylecarbs
Copy link
Member

This enables a consistent API for project import and provisioned resources.

@kylecarbs kylecarbs self-assigned this Feb 27, 2022
@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #369 (76fe3d9) into main (2d6804c) will decrease coverage by 0.49%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
- Coverage   68.27%   67.77%   -0.50%     
==========================================
  Files         150      150              
  Lines        8274     8333      +59     
  Branches       72       72              
==========================================
- Hits         5649     5648       -1     
- Misses       2057     2107      +50     
- Partials      568      578      +10     
Flag Coverage Δ
unittest-go-macos-latest ?
unittest-go-ubuntu-latest 67.71% <50.00%> (-0.28%) ⬇️
unittest-go-windows-2022 65.69% <50.00%> (-0.34%) ⬇️
unittest-js 66.10% <ø> (ø)
Impacted Files Coverage Δ
coderd/provisionerjobs.go 60.10% <ø> (ø)
codersdk/files.go 76.92% <ø> (+10.25%) ⬆️
coderd/workspaceagent.go 37.36% <18.91%> (-15.27%) ⬇️
coderd/projectimport.go 59.39% <50.00%> (ø)
codersdk/projectimport.go 64.40% <50.00%> (ø)
coderd/provisionerdaemons.go 59.69% <70.37%> (-0.82%) ⬇️
cli/projects.go 72.58% <100.00%> (-4.84%) ⬇️
peer/conn.go 76.47% <0.00%> (-3.33%) ⬇️
peerbroker/proxy.go 55.97% <0.00%> (-1.26%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d6804c...76fe3d9. Read the comment docs.

This enables a consistent API for project import and provisioned resources.
Copy link
Contributor

@bryphe-coder bryphe-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks for this refactoring!

Base automatically changed from tfprovider to main February 28, 2022 17:16
@kylecarbs kylecarbs enabled auto-merge (squash) February 28, 2022 17:20
@kylecarbs kylecarbs merged commit bd0293a into main Feb 28, 2022
@kylecarbs kylecarbs deleted the tfschema branch February 28, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants