Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix goroutine leak in peer exchange exit #370

Merged
merged 1 commit into from
Feb 28, 2022
Merged

test: Fix goroutine leak in peer exchange exit #370

merged 1 commit into from
Feb 28, 2022

Conversation

kylecarbs
Copy link
Member

Closes #361.

@kylecarbs kylecarbs self-assigned this Feb 27, 2022
@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #370 (a29a032) into main (f630fc5) will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
+ Coverage   67.46%   67.63%   +0.17%     
==========================================
  Files         148      148              
  Lines        8064     8064              
  Branches       72       72              
==========================================
+ Hits         5440     5454      +14     
+ Misses       2059     2048      -11     
+ Partials      565      562       -3     
Flag Coverage Δ
unittest-go-macos-latest 66.24% <ø> (+0.14%) ⬆️
unittest-go-ubuntu-latest 67.32% <ø> (+0.29%) ⬆️
unittest-go-windows-2022 65.79% <ø> (+0.13%) ⬆️
unittest-js 66.10% <ø> (ø)
Impacted Files Coverage Δ
provisionerd/provisionerd.go 69.92% <0.00%> (+0.58%) ⬆️
coderd/provisionerdaemons.go 60.80% <0.00%> (+0.59%) ⬆️
peerbroker/proxy.go 57.23% <0.00%> (+1.25%) ⬆️
peer/conn.go 77.49% <0.00%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f630fc5...a29a032. Read the comment docs.

Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable 👍

@kylecarbs kylecarbs merged commit 68ceea8 into main Feb 28, 2022
@kylecarbs kylecarbs deleted the peerleak branch February 28, 2022 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix goroutine leak in peer
2 participants