Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove magical parameters from being injected #371

Merged
merged 14 commits into from
Feb 28, 2022
Merged

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Feb 27, 2022

This is a much cleaner abstraction. Explicitly declaring the user
parameters for each provisioner makes for significantly simpler
testing.

@kylecarbs kylecarbs self-assigned this Feb 27, 2022
@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #371 (aed38ad) into main (bd0293a) will increase coverage by 0.32%.
The diff coverage is 82.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
+ Coverage   67.85%   68.17%   +0.32%     
==========================================
  Files         150      148       -2     
  Lines        8333     8169     -164     
  Branches       72       72              
==========================================
- Hits         5654     5569      -85     
+ Misses       2103     2042      -61     
+ Partials      576      558      -18     
Flag Coverage Δ
unittest-go-macos-latest 66.40% <80.64%> (+0.03%) ⬆️
unittest-go-ubuntu-latest 67.50% <82.85%> (+0.15%) ⬆️
unittest-go-windows-2022 ?
unittest-js 66.10% <ø> (ø)
Impacted Files Coverage Δ
cli/projectcreate.go 52.91% <ø> (+0.50%) ⬆️
coderd/coderd.go 95.37% <ø> (ø)
coderd/parameter/compute.go 71.85% <ø> (ø)
codersdk/files.go 66.66% <0.00%> (-10.26%) ⬇️
coderd/provisionerdaemons.go 59.52% <68.18%> (-0.18%) ⬇️
provisionerd/provisionerd.go 68.95% <78.57%> (-0.39%) ⬇️
coderd/cmd/root.go 82.43% <100.00%> (+0.48%) ⬆️
coderd/coderdtest/coderdtest.go 100.00% <100.00%> (ø)
provisioner/terraform/provider/provider.go 57.74% <100.00%> (+2.52%) ⬆️
provisioner/terraform/provision.go 74.64% <100.00%> (+0.44%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd0293a...aed38ad. Read the comment docs.

This is a much cleaner abstraction. Explicitly declaring the user
parameters for each provisioner makes for significantly simpler
testing.
Base automatically changed from tfschema to main February 28, 2022 18:00
@kylecarbs kylecarbs enabled auto-merge (squash) February 28, 2022 18:19
@kylecarbs kylecarbs merged commit e5c9555 into main Feb 28, 2022
@kylecarbs kylecarbs deleted the nomagicparams branch February 28, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants