Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix test flake panic in provisionerd #383

Merged
merged 1 commit into from
Feb 28, 2022
Merged

test: Fix test flake panic in provisionerd #383

merged 1 commit into from
Feb 28, 2022

Conversation

kylecarbs
Copy link
Member

Closes #382.

@kylecarbs kylecarbs self-assigned this Feb 28, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) February 28, 2022 19:50
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #383 (2758b1d) into main (8acd58a) will increase coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
+ Coverage   67.27%   67.81%   +0.53%     
==========================================
  Files         148      150       +2     
  Lines        8297     8475     +178     
  Branches       72       72              
==========================================
+ Hits         5582     5747     +165     
- Misses       2137     2149      +12     
- Partials      578      579       +1     
Flag Coverage Δ
unittest-go-macos-latest 66.16% <ø> (?)
unittest-go-ubuntu-latest 67.39% <ø> (ø)
unittest-go-windows-2022 65.51% <ø> (?)
unittest-js 66.10% <ø> (ø)
Impacted Files Coverage Δ
pty/pty_windows.go 60.31% <0.00%> (ø)
pty/start_windows.go 51.30% <0.00%> (ø)
peer/conn.go 77.74% <0.00%> (+0.76%) ⬆️
peerbroker/proxy.go 57.23% <0.00%> (+1.25%) ⬆️
provisionerd/provisionerd.go 68.56% <0.00%> (+1.28%) ⬆️
coderd/provisionerdaemons.go 57.82% <0.00%> (+1.60%) ⬆️
coderd/provisionerjobs.go 59.23% <0.00%> (+1.63%) ⬆️
coderd/workspacehistory.go 65.73% <0.00%> (+2.24%) ⬆️
provisioner/echo/serve.go 49.48% <0.00%> (+3.09%) ⬆️
coderd/workspaces.go 65.11% <0.00%> (+4.65%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8acd58a...2758b1d. Read the comment docs.

Copy link
Contributor

@bryphe-coder bryphe-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch - great testing monday contribution!

@kylecarbs kylecarbs merged commit fd5eceb into main Feb 28, 2022
@kylecarbs kylecarbs deleted the fixflake branch February 28, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix provisionerd test flake panic
2 participants