Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix flake with context.Cancelled in provisionerd #386

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

kylecarbs
Copy link
Member

This occurred because the context can cancel in the same time a response
is sent. This isn't a bug, because the complete still occurs.

https://github.com/coder/coder/runs/5366075943?check_suite_focus=true#step:7:56

This occurred because the context can cancel in the same time a response
is sent. This isn't a bug, because the complete still occurs.
@kylecarbs kylecarbs self-assigned this Mar 1, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) March 1, 2022 01:45
Copy link
Contributor

@bryphe-coder bryphe-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating these!

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #386 (8a2270d) into main (fd5eceb) will increase coverage by 1.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
+ Coverage   66.10%   67.71%   +1.61%     
==========================================
  Files          71      150      +79     
  Lines         773     8475    +7702     
  Branches       72       72              
==========================================
+ Hits          511     5739    +5228     
- Misses        248     2155    +1907     
- Partials       14      581     +567     
Flag Coverage Δ
unittest-go-macos-latest 66.17% <ø> (?)
unittest-go-ubuntu-latest 67.33% <ø> (?)
unittest-go-windows-2022 65.46% <ø> (?)
unittest-js 66.10% <ø> (ø)
Impacted Files Coverage Δ
provisioner/terraform/parse.go 77.77% <0.00%> (ø)
database/migrate.go 52.38% <0.00%> (ø)
database/time.go 0.00% <0.00%> (ø)
httpmw/projectparam.go 76.47% <0.00%> (ø)
coderd/provisionerdaemons.go 57.29% <0.00%> (ø)
coderd/workspaceagent.go 37.36% <0.00%> (ø)
cli/projectplan.go 62.50% <0.00%> (ø)
coderd/cmd/root.go 82.43% <0.00%> (ø)
codersdk/files.go 66.66% <0.00%> (ø)
database/pubsub_memory.go 87.17% <0.00%> (ø)
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd5eceb...8a2270d. Read the comment docs.

@kylecarbs kylecarbs merged commit ea5efbd into main Mar 1, 2022
@kylecarbs kylecarbs deleted the fixflakectx branch March 1, 2022 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants