test: Add mutex to opening PostgreSQL ports to prevent collision #389
Conversation
Codecov Report
@@ Coverage Diff @@
## main #389 +/- ##
==========================================
+ Coverage 67.92% 68.13% +0.20%
==========================================
Files 148 148
Lines 8297 8304 +7
Branches 72 72
==========================================
+ Hits 5636 5658 +22
+ Misses 2099 2088 -11
+ Partials 562 558 -4
Continue to review full report at Codecov.
|
| // Pick an explicit port on the host to connect to 5432. | ||
| // This is necessary so we can configure the port to only use ipv4. | ||
| port, err := getFreePort() | ||
| if err != nil { | ||
| openPortMutex.Unlock() |
There was a problem hiding this comment.
thought: Would it be safer to defer openPortMutex.Unlock() right after acquiring the lock? Just worried we may add a new if and forgot to unlock the mutex down the road.
There was a problem hiding this comment.
I had that initially but didn't want each execution to wait for the PostgreSQL instance to start up.
There was a problem hiding this comment.
We could separate out these functions though. I'm happy to do that if you feel it'd prevent a bug in the future!
Closes #388.