feat: Refactor API routes to use UUIDs instead of friendly names #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #401 +/- ##
==========================================
+ Coverage 67.57% 68.11% +0.54%
==========================================
Files 150 159 +9
Lines 8446 9318 +872
Branches 72 73 +1
==========================================
+ Hits 5707 6347 +640
- Misses 2159 2335 +176
- Partials 580 636 +56
Continue to review full report at Codecov.
|
bryphe-coder
reviewed
Mar 7, 2022
| r.Use( | ||
| httpmw.ExtractAPIKey(options.Database, nil), | ||
| httpmw.ExtractProjectParam(options.Database), | ||
| httpmw.ExtractOrganizationParam(options.Database), |
There was a problem hiding this comment.
Hmm, it doesn't seem like this would be used here?
There was a problem hiding this comment.
It ensures the caller has access to the organization the project resides in. Otherwise, users could access projects inside organizations they aren't in.
bryphe-coder
approved these changes
Mar 7, 2022
|
I updated the frontend too! |
|
Oh nice, thanks @kylecarbs ! I totally missed it - it was at the bottom of the PR and not expanded for some reason. Saw you updated the E2E test too 🙏 |
5 tasks
bryphe-coder
added a commit
that referenced
this pull request
Mar 9, 2022
…kspace page (#415) Some API routes were updated in #401, which impacted the UX - the flow is currently broken when trying to navigate to a project:  This fixes all the routes so that the complete project -> create workspace -> workspace page flow works:  Because this had to touch a bunch of UI routes, I also opportunistically fixed #380 as part of this change. Fixes #380
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drastically changes the API structure to use IDs instead of friendly names.
codersdk/*_test.goin favor of sharing coverage withcoderd/*.