Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use open-source Terraform Provider #403

Merged
merged 1 commit into from
Mar 7, 2022
Merged

feat: Use open-source Terraform Provider #403

merged 1 commit into from
Mar 7, 2022

Conversation

kylecarbs
Copy link
Member

This removes our internal Terraform Provider, and opens it to the world!

@kylecarbs kylecarbs self-assigned this Mar 7, 2022
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #403 (d41c369) into main (bf0ae8f) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   68.41%   68.25%   -0.16%     
==========================================
  Files         159      158       -1     
  Lines        9318     9227      -91     
  Branches       73       73              
==========================================
- Hits         6375     6298      -77     
+ Misses       2312     2307       -5     
+ Partials      631      622       -9     
Flag Coverage Δ
unittest-go-macos-latest 62.65% <100.00%> (-0.41%) ⬇️
unittest-go-ubuntu-latest 67.45% <100.00%> (+0.11%) ⬆️
unittest-go-windows-2022 62.23% <0.00%> (+0.06%) ⬆️
unittest-js 66.02% <ø> (ø)
Impacted Files Coverage Δ
provisionersdk/agent.go 100.00% <100.00%> (+22.22%) ⬆️
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
peer/conn.go 78.00% <0.00%> (-3.59%) ⬇️
codersdk/provisionerdaemons.go 58.46% <0.00%> (-3.08%) ⬇️
provisioner/echo/serve.go 57.50% <0.00%> (-2.50%) ⬇️
provisionerd/provisionerd.go 78.30% <0.00%> (-0.92%) ⬇️
peer/channel.go 83.04% <0.00%> (-0.59%) ⬇️
coderd/provisionerdaemons.go 57.60% <0.00%> (+0.54%) ⬆️
peerbroker/proxy.go 59.30% <0.00%> (+1.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf0ae8f...d41c369. Read the comment docs.

This removes our internal Terraform Provider, and opens
it to the world!
Copy link
Contributor

@bryphe-coder bryphe-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

list = append(list, key)
// AgentScriptEnv returns a key-pair of scripts that are consumed
// by the Coder Terraform Provider. See:
// https://github.com/coder/terraform-provider-coder/blob/main/internal/provider/provider.go#L97
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for referencing this back!

@kylecarbs kylecarbs merged commit 18c929c into main Mar 7, 2022
@kylecarbs kylecarbs deleted the rmprovider branch March 7, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants